spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #19448: [SPARK-22217] [SQL] ParquetFileFormat to support ...
Date Tue, 10 Oct 2017 23:27:03 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19448#discussion_r143879070
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
    @@ -138,6 +138,13 @@ class ParquetFileFormat
           conf.setBoolean(ParquetOutputFormat.ENABLE_JOB_SUMMARY, false)
         }
     
    +    if (conf.getBoolean(ParquetOutputFormat.ENABLE_JOB_SUMMARY, false)
    +      && !classOf[ParquetOutputCommitter].isAssignableFrom(committerClass)) {
    +      // output summary is requested, but the class is not a Parquet Committer
    +      throw new RuntimeException(s"Committer $committerClass is not a ParquetOutputCommitter"
+
    --- End diff --
    
    How about `require` maybe?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message