spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From susanxhuynh <...@git.apache.org>
Subject [GitHub] spark pull request #19374: [SPARK-22145][MESOS] fix supervise with checkpoin...
Date Mon, 09 Oct 2017 14:44:13 GMT
Github user susanxhuynh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19374#discussion_r143361887
  
    --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
    @@ -276,8 +276,8 @@ private[spark] class MesosClusterScheduler(
       private def recoverState(): Unit = {
         stateLock.synchronized {
           launchedDriversState.fetchAll[MesosClusterSubmissionState]().foreach { state =>
    -        launchedDrivers(state.taskId.getValue) = state
    -        pendingRecover(state.taskId.getValue) = state.slaveId
    +        launchedDrivers(state.driverDescription.submissionId) = state
    +        pendingRecover(state.taskId.toString) = state.slaveId
    --- End diff --
    
    Why did this change? I think the original `getValue` is the standard way to get the value
of this TaskID proto. http://mesos.apache.org/api/latest/java/org/apache/mesos/Protos.TaskID.html


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message