spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jerryshao <...@git.apache.org>
Subject [GitHub] spark pull request #19419: [SPARK-22188] [CORE] Adding security headers for ...
Date Mon, 09 Oct 2017 02:30:54 GMT
Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19419#discussion_r143377740
  
    --- Diff: conf/spark-defaults.conf.template ---
    @@ -25,3 +25,10 @@
     # spark.serializer                 org.apache.spark.serializer.KryoSerializer
     # spark.driver.memory              5g
     # spark.executor.extraJavaOptions  -XX:+PrintGCDetails -Dkey=value -Dnumbers="one two
three"
    +
    +# spark.ui.allowFramingFrom         https://www.example.com/
    --- End diff --
    
    Agree with @srowen , we should remove the configurations here in template, since they're
not common configurations. Also add them to `docs/configuration.md`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message