spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #19449: [SPARK-22219][SQL] Refactor code to get a value f...
Date Sun, 08 Oct 2017 03:39:12 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19449#discussion_r143345568
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
    @@ -929,7 +929,7 @@ class CodegenContext {
         // be extremely expensive in certain cases, such as deeply-nested expressions which
operate over
         // inputs with wide schemas. For more details on the performance issues that motivated
this
         // flat, see SPARK-15680.
    -    if (SparkEnv.get != null && SparkEnv.get.conf.getBoolean("spark.sql.codegen.comments",
false)) {
    --- End diff --
    
    I am afraid it might require a lot of code changes if we add SQLConf to `CodegenContext`.




---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message