spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #18931: [SPARK-21717][SQL] Decouple consume functions of ...
Date Sat, 07 Oct 2017 03:13:15 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18931#discussion_r143321131
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
    @@ -181,7 +181,7 @@ class WholeStageCodegenSuite extends SparkPlanTest with SharedSQLContext
{
         val codeWithShortFunctions = genGroupByCode(3)
         val (_, maxCodeSize1) = CodeGenerator.compile(codeWithShortFunctions)
         assert(maxCodeSize1 < SQLConf.WHOLESTAGE_HUGE_METHOD_LIMIT.defaultValue.get)
    -    val codeWithLongFunctions = genGroupByCode(20)
    +    val codeWithLongFunctions = genGroupByCode(50)
    --- End diff --
    
    We reduce the length of generated codes. So to make this test work, we increase the number
of expressions.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message