spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pgandhi999 <...@git.apache.org>
Subject [GitHub] spark pull request #19270: [SPARK-21809] : Change Stage Page to use datatabl...
Date Fri, 06 Oct 2017 19:33:22 GMT
Github user pgandhi999 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19270#discussion_r143277618
  
    --- Diff: core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala ---
    @@ -346,7 +346,7 @@ class UISeleniumSuite extends SparkFunSuite with WebBrowser with Matchers
with B
     
           for {
             stageId <- 0 to 1
    -        attemptId <- 0 to 1
    +        attemptId <- 1 to 0
    --- End diff --
    
    So this test was initially failing due to following reason. For stage id 1 and attempt
id 0, the stage is designed to fail. So ideally, for this case, when the test tries to connect
to the backend to get the json file in line 352, it would exit. But as there is no code writen
to handle the exception, the test would quit and fail as the last case never ran. So, by changing
the order, I ensured that all the stage success cases would run and the last one would fail
and test will pass. I went as far as I could to debug and this was what I could find. If you
think there is something more to this, let me know and we can discuss further.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message