spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request #19250: [SPARK-12297] Table timezone correction for Times...
Date Fri, 06 Oct 2017 07:12:22 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19250#discussion_r143122317
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
    @@ -1213,6 +1213,71 @@ case class ToUTCTimestamp(left: Expression, right: Expression)
     }
     
     /**
    + * This modifies a timestamp to show how the display time changes going from one timezone
to
    + * another, for the same instant in time.
    + *
    + * We intentionally do not provide an ExpressionDescription as this is not meant to be
exposed to
    + * users, its only used for internal conversions.
    + */
    +private[spark] case class TimestampTimezoneCorrection(
    --- End diff --
    
    do we need a whole expression for this? can't we just reuse existing expressions? It's
just simple arithmetics isn't it?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message