spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark pull request #19436: [SPARK-22206][SQL][SparkR] gapply in R can't work...
Date Thu, 05 Oct 2017 05:19:22 GMT
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19436#discussion_r142849580
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/objects.scala ---
    @@ -394,7 +394,11 @@ case class FlatMapGroupsInRExec(
       override def producedAttributes: AttributeSet = AttributeSet(outputObjAttr)
     
       override def requiredChildDistribution: Seq[Distribution] =
    -    ClusteredDistribution(groupingAttributes) :: Nil
    +    if (groupingAttributes.isEmpty) {
    +      AllTuples :: Nil
    --- End diff --
    
    should empty == all?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message