spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #19061: [SPARK-21568][CORE] ConsoleProgressBar should onl...
Date Wed, 04 Oct 2017 02:36:17 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19061#discussion_r142570193
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -598,6 +598,15 @@ object SparkSubmit extends CommandLineUtils with Logging {
           }
         }
     
    +    // In case of shells, spark.ui.showConsoleProgress can be true by default or by user.
    +    if (isShell(args.primaryResource)) {
    +      if (!sparkConf.contains("spark.ui.showConsoleProgress")) {
    +        sysProps("spark.ui.showConsoleProgress") = "true"
    +      }
    +    } else {
    +      sysProps("spark.ui.showConsoleProgress") = "false"
    --- End diff --
    
    Originally, I prefer blocking it from here. Please comment me back if this should be removed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message