spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #19392: [SPARK-22169][SQL] table name with numbers and ch...
Date Mon, 02 Oct 2017 23:02:58 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19392#discussion_r142277890
  
    --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
---
    @@ -510,11 +510,15 @@ rowFormat
         ;
     
     tableIdentifier
    -    : (db=identifier '.')? table=identifier
    +    : (db=identifierPart '.')? table=identifierPart
         ;
     
     functionIdentifier
    -    : (db=identifier '.')? function=identifier
    +    : (db=identifierPart '.')? function=identifierPart
    +    ;
    +
    +identifierPart
    +    : identifier | BIGINT_LITERAL | SMALLINT_LITERAL | TINYINT_LITERAL | BYTELENGTH_LITERAL
    --- End diff --
    
    But the rule in `validateName` allows a name consisting of numbers.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message