spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From MLnick <...@git.apache.org>
Subject [GitHub] spark pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Wor...
Date Mon, 02 Oct 2017 19:29:07 GMT
Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17673#discussion_r142218654
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/Word2VecSuite.scala ---
    @@ -245,5 +508,28 @@ class Word2VecSuite extends SparkFunSuite with MLlibTestSparkContext
with Defaul
         model.transform(ngramDF).collect()
       }
     
    +  test("Word2Vec works with input that is non-nullable (NGram) - CBOW") {
    --- End diff --
    
    Can this test not just be folded into the one above?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message