Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 045BB200D08 for ; Thu, 21 Sep 2017 15:59:43 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 00F8B1609D0; Thu, 21 Sep 2017 13:59:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3EA811609B8 for ; Thu, 21 Sep 2017 15:59:42 +0200 (CEST) Received: (qmail 71848 invoked by uid 500); 21 Sep 2017 13:59:41 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 71837 invoked by uid 99); 21 Sep 2017 13:59:41 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Sep 2017 13:59:41 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 19F96F5613; Thu, 21 Sep 2017 13:59:41 +0000 (UTC) From: WeichenXu123 To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #18924: [SPARK-14371] [MLLIB] OnlineLDAOptimizer should n... Content-Type: text/plain Message-Id: <20170921135941.19F96F5613@git1-us-west.apache.org> Date: Thu, 21 Sep 2017 13:59:41 +0000 (UTC) archived-at: Thu, 21 Sep 2017 13:59:43 -0000 Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/18924#discussion_r140249325 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala --- @@ -503,17 +518,15 @@ final class OnlineLDAOptimizer extends LDAOptimizer { } /** - * Update alpha based on `gammat`, the inferred topic distributions for documents in the - * current mini-batch. Uses Newton-Rhapson method. + * Update alpha based on `logphat`. --- End diff -- I think it doesn't matter if `seq` do not return left param reference but return a new object. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org