Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AFD63200D19 for ; Thu, 21 Sep 2017 12:40:39 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AE8921609B8; Thu, 21 Sep 2017 10:40:39 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F33B31609D0 for ; Thu, 21 Sep 2017 12:40:38 +0200 (CEST) Received: (qmail 65099 invoked by uid 500); 21 Sep 2017 10:40:38 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 65054 invoked by uid 99); 21 Sep 2017 10:40:38 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Sep 2017 10:40:38 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E9FE0F3323; Thu, 21 Sep 2017 10:40:37 +0000 (UTC) From: HyukjinKwon To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request #19305: [SPARK-22088][SQL] Incorrect scalastyle comment c... Content-Type: text/plain Message-Id: <20170921104037.E9FE0F3323@git1-us-west.apache.org> Date: Thu, 21 Sep 2017 10:40:37 +0000 (UTC) archived-at: Thu, 21 Sep 2017 10:40:39 -0000 Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19305#discussion_r140206696 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -548,6 +551,7 @@ object StringTrim { > SELECT _FUNC_(BOTH 'SL' FROM 'SSparkSQLS'); parkSQ """) +// scalastyle:on line.size.limit --- End diff -- Here too, it looks we are fine okay without disabling it. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org