spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #19382: [SPARK-22158][SQL] convertMetastoreOrc/Parquet sh...
Date Fri, 29 Sep 2017 17:12:05 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19382#discussion_r141919805
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
    @@ -189,12 +189,12 @@ case class RelationConversions(
       private def convert(relation: HiveTableRelation): LogicalRelation = {
         val serde = relation.tableMeta.storage.serde.getOrElse("").toLowerCase(Locale.ROOT)
         if (serde.contains("parquet")) {
    -      val options = Map(ParquetOptions.MERGE_SCHEMA ->
    +      val options = relation.tableMeta.storage.properties + (ParquetOptions.MERGE_SCHEMA
->
    --- End diff --
    
    Hi, @gatorsmile . It's the same in the Paquet. Without this, the test case for parquet
fails.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message