spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #19324: [SPARK-22103] Move HashAggregateExec parent consu...
Date Tue, 26 Sep 2017 12:16:25 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19324#discussion_r141037611
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
---
    @@ -186,8 +186,7 @@ case class BroadcastHashJoinExec(
        */
       private def getJoinCondition(
           ctx: CodegenContext,
    -      input: Seq[ExprCode],
    -      anti: Boolean = false): (String, String, Seq[ExprCode]) = {
    --- End diff --
    
    so we never set it to true?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message