spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BryanCutler <...@git.apache.org>
Subject [GitHub] spark pull request #19325: [SPARK-22106][PYSPARK][SQL] Disable 0-parameter p...
Date Mon, 25 Sep 2017 16:50:37 GMT
Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19325#discussion_r140833242
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -2183,14 +2183,29 @@ def pandas_udf(f=None, returnType=StringType()):
         :param f: python function if used as a standalone function
         :param returnType: a :class:`pyspark.sql.types.DataType` object
     
    -    # TODO: doctest
    +    >>> from pyspark.sql.types import IntegerType, StringType
    +    >>> slen = pandas_udf(lambda s: s.str.len(), IntegerType())
    +    >>> @pandas_udf(returnType=StringType())
    --- End diff --
    
    Hmm, I thought that the Jenkins environment for unit tests would be the same for doctests
and have pyarrow installed. @holdenk or @shaneknapp do you know if that is the case?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message