spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From juliuszsompolski <...@git.apache.org>
Subject [GitHub] spark pull request #19324: [SPARK-22103] Move HashAggregateExec parent consu...
Date Fri, 22 Sep 2017 15:46:28 GMT
Github user juliuszsompolski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19324#discussion_r140528883
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
    @@ -329,6 +332,15 @@ case class WholeStageCodegenExec(child: SparkPlan) extends UnaryExecNode
with Co
       def doCodeGen(): (CodegenContext, CodeAndComment) = {
         val ctx = new CodegenContext
         val code = child.asInstanceOf[CodegenSupport].produce(ctx, this)
    +
    +    // main next function.
    +    ctx.addNewFunction("processNext",
    --- End diff --
    
    tangent fix: add processNext() as a separate function, so that it is also taken into account
by https://github.com/apache/spark/pull/18810


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message