spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #17902: [SPARK-20641][core] Add key-value store abstracti...
Date Thu, 21 Sep 2017 16:19:03 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17902#discussion_r140290617
  
    --- Diff: common/kvstore/src/main/java/org/apache/spark/kvstore/KVStoreSerializer.java
---
    @@ -0,0 +1,86 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.kvstore;
    +
    +import java.io.ByteArrayInputStream;
    +import java.io.ByteArrayOutputStream;
    +import java.util.zip.GZIPInputStream;
    +import java.util.zip.GZIPOutputStream;
    +import static java.nio.charset.StandardCharsets.UTF_8;
    +
    +import com.fasterxml.jackson.databind.ObjectMapper;
    +
    +/**
    + * Serializer used to translate between app-defined types and the LevelDB store.
    + *
    + * <p>
    + * The serializer is based on Jackson, so values are written as JSON. It also allows
"naked strings"
    + * and integers to be written as values directly, which will be written as UTF-8 strings.
    + * </p>
    + */
    +public class KVStoreSerializer {
    +
    +  /**
    +   * Object mapper used to process app-specific types. If an application requires a specific
    +   * configuration of the mapper, it can subclass this serializer and add custom configuration
    +   * to this object.
    +   */
    +  protected final ObjectMapper mapper;
    +
    +  public KVStoreSerializer() {
    +    this.mapper = new ObjectMapper();
    +  }
    +
    +  public final byte[] serialize(Object o) throws Exception {
    +    if (o instanceof String) {
    --- End diff --
    
    Classes are handled by Jackson (the "else").


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message