spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From WeichenXu123 <...@git.apache.org>
Subject [GitHub] spark pull request #18924: [SPARK-14371] [MLLIB] OnlineLDAOptimizer should n...
Date Thu, 21 Sep 2017 13:59:41 GMT
Github user WeichenXu123 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18924#discussion_r140249325
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
    @@ -503,17 +518,15 @@ final class OnlineLDAOptimizer extends LDAOptimizer {
       }
     
       /**
    -   * Update alpha based on `gammat`, the inferred topic distributions for documents in
the
    -   * current mini-batch. Uses Newton-Rhapson method.
    +   * Update alpha based on `logphat`.
    --- End diff --
    
    I think it doesn't matter if `seq` do not return left param reference but return a new
object.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message