spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #19307: [SPARK-22087][SPARK-14650][WIP][BUILD][REPL][CORE...
Date Thu, 21 Sep 2017 11:10:21 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19307#discussion_r140211712
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala ---
    @@ -230,19 +230,16 @@ class DataFrameStatSuite extends QueryTest with SharedSQLContext
{
     
         val resNaN1 = dfNaN.stat.approxQuantile("input1", Array(q1, q2), epsilon)
         assert(resNaN1.count(_.isNaN) === 0)
    -    assert(resNaN1.count(_ == null) === 0)
    --- End diff --
    
    resNaN1 is an Array[Double] so can never contain null. This is always true and generated
a warning


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message