spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #19211: [SPARK-18838][core] Add separate listener queues ...
Date Wed, 20 Sep 2017 05:23:57 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19211#discussion_r139877613
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala ---
    @@ -39,20 +41,13 @@ import org.apache.spark.util.Utils
      * has started will events be actually propagated to all attached listeners. This listener
bus
      * is stopped when `stop()` is called, and it will drop further events after stopping.
      */
    -private[spark] class LiveListenerBus(conf: SparkConf) extends SparkListenerBus {
    -
    -  self =>
    +private[spark] class LiveListenerBus(conf: SparkConf) {
    --- End diff --
    
    oh sorry I missed that, `LiveListenerBus` doesn't extend `SparkListenerBus` anymore.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message