spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maropu <...@git.apache.org>
Subject [GitHub] spark pull request #19266: [SPARK-22033][CORE] BufferHolder, other size chec...
Date Tue, 19 Sep 2017 02:01:06 GMT
Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19266#discussion_r139582421
  
    --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/array/LongArray.java ---
    @@ -39,7 +39,7 @@
       private final long length;
     
       public LongArray(MemoryBlock memory) {
    -    assert memory.size() < (long) Integer.MAX_VALUE * 8: "Array size > 4 billion
elements";
    +    assert memory.size() < (long) Integer.MAX_VALUE * 8: "Array size > 2.1 billion
elements";
    --- End diff --
    
    We need the same assert below?
     https://github.com/apache/spark/blob/c66d64b3df9d9ffba0b16a62015680f6f876fc68/common/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java#L53


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message