spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...
Date Wed, 13 Sep 2017 23:04:08 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19041#discussion_r138753970
  
    --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -108,6 +110,10 @@ private[spark] class ExecutorAllocationManager(
       private val cachedExecutorIdleTimeoutS = conf.getTimeAsSeconds(
         "spark.dynamicAllocation.cachedExecutorIdleTimeout", s"${Integer.MAX_VALUE}s")
     
    +  // whether or not to try and save cached data when executors are deallocated
    +  private val replicateCachedData =
    +    conf.getBoolean("spark.dynamicAllocation.recoverCachedData", defaultValue = false)
    --- End diff --
    
    Please add a config constant in `core/src/main/scala/org/apache/spark/internal/config/package.scala`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message