spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...
Date Wed, 13 Sep 2017 23:04:08 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19041#discussion_r138761473
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMessages.scala ---
    @@ -116,4 +121,11 @@ private[spark] object BlockManagerMessages {
       case class BlockManagerHeartbeat(blockManagerId: BlockManagerId) extends ToBlockManagerMaster
     
       case class HasCachedBlocks(executorId: String) extends ToBlockManagerMaster
    +
    +  case class GetCachedBlocks(executorId: String) extends ToBlockManagerMaster
    +
    +  case class GetSizeOfBlocks(blocks: Seq[(String, BlockId)]) extends ToBlockManagerMaster
    +
    +  case class ReplicateOneBlock(executorId: String, blockId: BlockId, exclude: Seq[String])
    --- End diff --
    
    `exclude` should at least be consistent with the name of the corresponding argument in
`ReplicateBlock`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message