spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #18266: [SPARK-20427][SQL] Read JDBC table use custom sch...
Date Fri, 08 Sep 2017 06:58:49 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18266#discussion_r137720936
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
    @@ -197,7 +197,7 @@ class DataFrameReader private[sql](sparkSession: SparkSession) extends
Logging {
        * @since 1.4.0
        */
       def jdbc(url: String, table: String, properties: Properties): DataFrame = {
    -    assertNoSpecifiedSchema("jdbc")
    +    assertJdbcAPISpecifiedDataFrameSchema()
    --- End diff --
    
    Users should be able to do it in either way. If users specify them in both `schema()`
API and the `customerSchema` option, we should issue an exception.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message