spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #19148: [SPARK-21936][SQL] backward compatibility test fr...
Date Fri, 08 Sep 2017 02:48:12 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19148#discussion_r137699802
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/SparkSubmitTestUtils.scala
---
    @@ -0,0 +1,101 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.hive
    +
    +import java.io.File
    +import java.sql.Timestamp
    +import java.util.Date
    +
    +import scala.collection.mutable.ArrayBuffer
    +
    +import org.scalatest.concurrent.Timeouts
    +import org.scalatest.exceptions.TestFailedDueToTimeoutException
    +import org.scalatest.time.SpanSugar._
    +
    +import org.apache.spark.SparkFunSuite
    +import org.apache.spark.sql.test.ProcessTestUtils.ProcessOutputCapturer
    +import org.apache.spark.util.Utils
    +
    +trait SparkSubmitTestUtils extends SparkFunSuite with Timeouts {
    --- End diff --
    
    nit. Let's use `TimeLimits` instead of `Timeouts`. `Timeouts` is deprecated now.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message