spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #19124: [SPARK-21912][SQL] Creating ORC/Parquet datasourc...
Date Tue, 05 Sep 2017 23:55:55 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19124#discussion_r137143172
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
    @@ -130,10 +130,12 @@ case class DataSourceAnalysis(conf: SQLConf) extends Rule[LogicalPlan]
with Cast
     
       override def apply(plan: LogicalPlan): LogicalPlan = plan transform {
         case CreateTable(tableDesc, mode, None) if DDLUtils.isDatasourceTable(tableDesc)
=>
    +      DDLUtils.checkFieldNames(tableDesc)
           CreateDataSourceTableCommand(tableDesc, ignoreIfExists = mode == SaveMode.Ignore)
     
         case CreateTable(tableDesc, mode, Some(query))
             if query.resolved && DDLUtils.isDatasourceTable(tableDesc) =>
    +      DDLUtils.checkFieldNames(tableDesc.copy(schema = query.schema))
           CreateDataSourceTableAsSelectCommand(tableDesc, mode, query)
     
         case InsertIntoTable(l @ LogicalRelation(_: InsertableRelation, _, _, _),
    --- End diff --
    
    Since this PR is not big, it should cover all these scenarios. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message