spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #19124: [SPARK-21912][SQL] Creating ORC/Parquet datasourc...
Date Tue, 05 Sep 2017 20:39:16 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19124#discussion_r137107658
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala ---
    @@ -83,6 +83,8 @@ class OrcFileFormat extends FileFormat with DataSourceRegister with
Serializable
               classOf[MapRedOutputFormat[_, _]])
         }
     
    +    org.apache.spark.sql.execution.datasources.orc.OrcFileFormat.checkFieldNames(dataSchema)
    --- End diff --
    
    I see. I'll check this and remove it. Maybe, we can remove the similar logic from ParquetFileFormat,
too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message