spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark issue #19134: [SPARK-21893][BUILD][STREAMING][WIP] Put Kafka 0.8 behin...
Date Tue, 05 Sep 2017 17:44:31 GMT
Github user vanzin commented on the issue:

    https://github.com/apache/spark/pull/19134
  
    For python I think you just do what kinesis does:
    
    ```
    # Must be same as the variable and condition defined in KinesisTestUtils.scala
    kinesis_test_environ_var = "ENABLE_KINESIS_TESTS"
    are_kinesis_tests_enabled = os.environ.get(kinesis_test_environ_var) == '1'
    ```
    
    The comment is misleading though, since that variable is set in `modules.py` which you
are already modifying.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message