Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: eatoncys <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-19022-spark@git.apache.org>
In-Reply-To: <git-pr-19022-spark@git.apache.org>
Subject: [GitHub] spark pull request #19022: [Spark-21807][SQL]Override ++ operation in Expres...
Content-Type: text/plain
Message-Id: <20170824005830.1025FE088D@git1-us-west.apache.org>
Date: Thu, 24 Aug 2017 00:58:30 +0000 (UTC)
archived-at: Thu, 24 Aug 2017 00:58:31 -0000

Github user eatoncys commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19022#discussion_r134905955
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSetSuite.scala ---
    @@ -210,4 +210,13 @@ class ExpressionSetSuite extends SparkFunSuite {
         assert((initialSet - (aLower + 1)).size == 0)
     
       }
    +
    +  test("add multiple elements to set") {
    +    val initialSet = ExpressionSet(aUpper + 1 :: Nil)
    +    val setToAddWithSameExpression = ExpressionSet(aUpper + 1 :: aUpper + 2 :: Nil)
    +    val setToAdd = ExpressionSet(aUpper + 2 :: aUpper + 3 :: Nil)
    --- End diff --
    
    Yes, I have modified the name to setToAddWithOutSameExpression.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org