Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: ueshin <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-18958-spark@git.apache.org>
In-Reply-To: <git-pr-18958-spark@git.apache.org>
Subject: [GitHub] spark pull request #18958: [SPARK-21745][SQL] Refactor ColumnVector hierarch...
Content-Type: text/plain
Message-Id: <20170821053807.40792E7DFA@git1-us-west.apache.org>
Date: Mon, 21 Aug 2017 05:38:07 +0000 (UTC)
archived-at: Mon, 21 Aug 2017 05:38:09 -0000

Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18958#discussion_r134148287
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java ---
    @@ -970,30 +458,14 @@ public final int appendStruct(boolean isNull) {
       protected boolean anyNullsSet;
     
       /**
    -   * True if this column's values are fixed. This means the column values never change, even
    -   * across resets.
    -   */
    -  protected boolean isConstant;
    -
    -  /**
    -   * Default size of each array length value. This grows as necessary.
    -   */
    -  protected static final int DEFAULT_ARRAY_LENGTH = 4;
    -
    -  /**
    -   * Current write cursor (row index) when appending data.
    -   */
    -  protected int elementsAppended;
    -
    -  /**
        * If this is a nested type (array or struct), the column for the child data.
        */
       protected ColumnVector[] childColumns;
    --- End diff --
    
    We need this field for `ArrowColumnVector` to store its child columns, too.
    Do you want to make the method `getChildColumn(int ordinal)` abstract and move the field to more concrete classes to manage by themselves?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org