Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: gatorsmile <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-18926-spark@git.apache.org>
In-Reply-To: <git-pr-18926-spark@git.apache.org>
Subject: [GitHub] spark issue #18926: [SPARK-21712] [PySpark] Clarify type error for Column.su...
Content-Type: text/plain
Message-Id: <20170815063426.58A3EF3317@git1-us-west.apache.org>
Date: Tue, 15 Aug 2017 06:34:25 +0000 (UTC)
archived-at: Tue, 15 Aug 2017 06:34:30 -0000

Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/18926
  
    Even if we plan to drop `long` in this PR, [the checking](https://github.com/nchammas/spark/blob/fc1d84f002f5bd66bcad038a5581a05ade8dbc35/python/pyspark/sql/column.py#L408) looks weird to me. Basically, the change just wants to ensure the type of `length ` is `int`.
    
    Since this PR is pretty small, we should fix the issue instead of opening another one. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org