Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: marmbrus <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-18925-spark@git.apache.org>
In-Reply-To: <git-pr-18925-spark@git.apache.org>
Subject: [GitHub] spark pull request #18925: [SPARK-21713][SC] Replace streaming bit with Outp...
Content-Type: text/plain
Message-Id: <20170811220242.7F689E964E@git1-us-west.apache.org>
Date: Fri, 11 Aug 2017 22:02:42 +0000 (UTC)
archived-at: Fri, 11 Aug 2017 22:02:44 -0000

Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18925#discussion_r132791950
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala ---
    @@ -779,10 +780,16 @@ case object OneRowRelation extends LeafNode {
     }
     
     /** A logical plan for `dropDuplicates`. */
    +case object Deduplicate {
    +  def apply(keys: Seq[Attribute], child: LogicalPlan): Deduplicate = {
    +    Deduplicate(keys, child, child.outputMode)
    +  }
    +}
    +
     case class Deduplicate(
         keys: Seq[Attribute],
         child: LogicalPlan,
    -    streaming: Boolean) extends UnaryNode {
    +    originalOutputMode: OutputMode) extends UnaryNode {
    --- End diff --
    
    Can we drop this?  Can it just preserve the output mode of its child?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org