Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: caneGuy <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-18901-spark@git.apache.org>
In-Reply-To: <git-pr-18901-spark@git.apache.org>
Subject: [GitHub] spark pull request #18901: [SPARK-21689][YARN] Download user jar from remote...
Content-Type: text/plain
Message-Id: <20170810073209.ABBCBE9456@git1-us-west.apache.org>
Date: Thu, 10 Aug 2017 07:32:09 +0000 (UTC)
archived-at: Thu, 10 Aug 2017 07:32:11 -0000

Github user caneGuy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18901#discussion_r132381900
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -516,6 +516,10 @@ object SparkSubmit extends CommandLineUtils {
         if (deployMode == CLIENT || isYarnCluster) {
           childMainClass = args.mainClass
           if (isUserJar(args.primaryResource)) {
    +        val hadoopConf = new HadoopConfiguration()
    +        args.primaryResource =
    +          Option(args.primaryResource).map(
    +            downloadFile(_, targetDir, args.sparkProperties, hadoopConf)).orNull
             childClasspath += args.primaryResource
           }
           if (args.jars != null) { childClasspath ++= args.jars.split(",") }
    --- End diff --
    
    I agree with you, and updated the logic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org