Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: wangyum <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-18841-spark@git.apache.org>
In-Reply-To: <git-pr-18841-spark@git.apache.org>
Subject: [GitHub] spark pull request #18841: [SPARK-21635][SQL] ACOS(2) and ASIN(2) should be ...
Content-Type: text/plain
Message-Id: <20170805164034.0CA18E0202@git1-us-west.apache.org>
Date: Sat,  5 Aug 2017 16:40:33 +0000 (UTC)
archived-at: Sat, 05 Aug 2017 16:40:36 -0000

Github user wangyum commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18841#discussion_r131525404
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala ---
    @@ -170,29 +193,29 @@ case class Pi() extends LeafMathExpression(math.Pi, "PI")
     
     // scalastyle:off line.size.limit
     @ExpressionDescription(
    -  usage = "_FUNC_(expr) - Returns the inverse cosine (a.k.a. arccosine) of `expr` if -1<=`expr`<=1 or NaN otherwise.",
    +  usage = "_FUNC_(expr) - Returns the inverse cosine (a.k.a. arccosine) of `expr` if -1<=`expr`<=1 or NULL otherwise.",
       extended = """
         Examples:
           > SELECT _FUNC_(1);
            0.0
           > SELECT _FUNC_(2);
    -       NaN
    +       NULL
    --- End diff --
    
    Spark handles some `NaN`:
    https://github.com/apache/spark/blob/v2.2.0/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala#L84
    
    I think Spark keeps pace with the database as much as possible, otherwise SQL migration is troublesome. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org