Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4BFB0200CD8 for ; Wed, 2 Aug 2017 10:51:32 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4A6B91690C2; Wed, 2 Aug 2017 08:51:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 87CB01690C1 for ; Wed, 2 Aug 2017 10:51:31 +0200 (CEST) Received: (qmail 96300 invoked by uid 500); 2 Aug 2017 08:51:30 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 96284 invoked by uid 99); 2 Aug 2017 08:51:30 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Aug 2017 08:51:30 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 672CCE00C5; Wed, 2 Aug 2017 08:51:30 +0000 (UTC) From: maropu To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark issue #18779: [SPARK-21580][SQL]Integers in aggregation expressions ar... Content-Type: text/plain Message-Id: <20170802085130.672CCE00C5@git1-us-west.apache.org> Date: Wed, 2 Aug 2017 08:51:30 +0000 (UTC) archived-at: Wed, 02 Aug 2017 08:51:32 -0000 Github user maropu commented on the issue: https://github.com/apache/spark/pull/18779 @viirya yea, it does: https://github.com/apache/spark/compare/master...maropu:SPARK-21580#diff-a0f2e45a5da747e9ec483f3557aa1b8bR210. I also think `SubstituteUnresolvedOrdinals` should be applied once. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org