spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maropu <...@git.apache.org>
Subject [GitHub] spark pull request #19021: [SPARK-21603][SQL][FOLLOW-UP] Change the default ...
Date Tue, 22 Aug 2017 08:20:20 GMT
GitHub user maropu opened a pull request:

    https://github.com/apache/spark/pull/19021

    [SPARK-21603][SQL][FOLLOW-UP] Change the default value of maxLinesPerFunction into 4000

    ## What changes were proposed in this pull request?
    This pr changed the default value of `maxLinesPerFunction` into `4000`. In #18810, we
had this new option to disable code generation for too long functions and I found this option
only affected `Q17` and `Q66` in TPC-DS. But, `Q66` had some performance regression:
    
    ```
    Q17 w/o #18810, 3224ms   --> q17 w/#18810, 2627ms (improvement)
    Q66 w/o #18810, 1712ms -->  q66 w/#18810, 3032ms (regression)
    ```
    
    To keep the previous performance in TPC-DS, we better set higher value at `maxLinesPerFunction`
by default.
    
    ## How was this patch tested?
    Existing tests.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maropu/spark SPARK-21603-FOLLOWUP-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19021.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19021
    
----
commit d0bc6a62cd58147c9809d9c99fd4452cf7e40aff
Author: Takeshi Yamamuro <yamamuro@apache.org>
Date:   2017-08-22T08:05:29Z

    Change the default value of maxLinesPerFunction into 4000

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message