spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #19050: [SPARK-21835][SQL][WIP] RewritePredicateSubquery ...
Date Mon, 28 Aug 2017 05:17:57 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19050#discussion_r135443202
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
    @@ -98,6 +99,11 @@ object RewritePredicateSubquery extends Rule[LogicalPlan] with PredicateHelper
{
               val (newCond, inputPlan) = rewriteExistentialExpr(Seq(predicate), p)
               Project(p.output, Filter(newCond.get, inputPlan))
           }
    +
    +      rewrotePlan transform {
    +        case j @ Join(left, right, _, _) if !j.duplicateResolved =>
    +          j.copy(right = DedupQueryAttributesInPlans.dedupRight(left, right))
    --- End diff --
    
    @hvanhovell We may not be able to revise `duplicateResolved`.
    
    Even LeftSemi do output from only left side of the join, we still need `duplicateResolved`
as false if there are duplicate attributes between left and right sides.
    
    Otherwise, if there is a condition, the condition will be pushdown to left side of the
join, because all attribute references in the condition is belonging to one side. It changes
the join results.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message