spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guoxiaolongzte <...@git.apache.org>
Subject [GitHub] spark pull request #19049: [WEB-UI]Add the 'master' column to identify the t...
Date Mon, 28 Aug 2017 01:04:56 GMT
Github user guoxiaolongzte commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19049#discussion_r135427302
  
    --- Diff: core/src/main/resources/org/apache/spark/ui/static/historypage.js ---
    @@ -136,6 +136,16 @@ $(document).ready(function() {
                 (attempt.hasOwnProperty("attemptId") ? attempt["attemptId"] + "/" : "") +
"logs";
               attempt["durationMillisec"] = attempt["duration"];
               attempt["duration"] = formatDuration(attempt["duration"]);
    +          var idStr = id.toString();
    +          if(idStr.indexOf("application_") > -1) {
    +            attempt["master"] = "yarn";
    +          } else if(idStr.indexOf("app-") > -1) {
    +            attempt["master"] = "standalone";
    +          } else if(idStr.indexOf("local-") > -1) {
    +            attempt["master"] = "local";
    +          } else {
    +            attempt["master"] = "mesos";
    --- End diff --
    
    I am through the ID to judge, not through the name to judge. ID is based on the type of
resource management to determine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message