spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #18966: [SPARK-21751][SQL] CodeGeneraor.splitExpressions ...
Date Fri, 25 Aug 2017 18:41:34 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18966#discussion_r135327262
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -582,6 +582,15 @@ object SQLConf {
         .intConf
         .createWithDefault(2667)
     
    +  val CODEGEN_MAX_LINES_PER_FUNCTION = buildConf("spark.sql.codegen.maxCodegenLinesPerFunction")
    +    .internal()
    +    .doc("The maximum lines of a single Java function generated by codegen. " +
    --- End diff --
    
    We might need to emphasize this is not for whole-stage codegen. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message