spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #19044: [SPARK-21832][TEST] Merge SQLBuilderTest into Exp...
Date Thu, 24 Aug 2017 23:52:06 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19044#discussion_r135157926
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/catalyst/ExpressionSQLBuilderSuite.scala
---
    @@ -19,12 +19,28 @@ package org.apache.spark.sql.catalyst
     
     import java.sql.Timestamp
     
    -import org.apache.spark.sql.catalyst.dsl.expressions._
    -import org.apache.spark.sql.catalyst.expressions.{If, Literal, SpecifiedWindowFrame,
TimeAdd,
    -  TimeSub, WindowSpecDefinition}
    +import org.apache.spark.sql.QueryTest
    +import org.apache.spark.sql.catalyst.expressions._
    +import org.apache.spark.sql.hive.test.TestHiveSingleton
     import org.apache.spark.unsafe.types.CalendarInterval
     
    -class ExpressionSQLBuilderSuite extends SQLBuilderTest {
    +class ExpressionSQLBuilderSuite extends QueryTest with TestHiveSingleton {
    +  protected def checkSQL(e: Expression, expectedSQL: String): Unit = {
    +    val actualSQL = e.sql
    +    try {
    +      assert(actualSQL === expectedSQL)
    --- End diff --
    
    I see. Yep. That's better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message