spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark issue #18488: [SPARK-21255][SQL][WIP] Fixed NPE when creating encoder ...
Date Tue, 22 Aug 2017 11:47:14 GMT
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/18488
  
    I don't feel especially qualified to review this, and I'm hesitant because I know the
core encoder/decoder framework is an important piece that needs some care.
    
    Your change looks good though. It does seem carefully targeted at only changing the enum
cases, has tests, and does fix an identified problem that prevents a normal use case from
working.
    
    Am I right that this serializes enums as their string value?
    
    Are there any downsides to this change -- am I missing any behavior it changes or breaks?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message