spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #18994: [SPARK-21784][SQL] Adds support for defining info...
Date Mon, 21 Aug 2017 04:51:57 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18994#discussion_r134145171
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala
---
    @@ -1214,6 +1246,11 @@ object HiveExternalCatalog {
     
       val CREATED_SPARK_VERSION = SPARK_SQL_PREFIX + "create.version"
     
    +  val TABLE_CONSTRAINT_PREFIX = SPARK_SQL_PREFIX + "constraint."
    +  val TABLE_CONSTRAINT_PRIMARY_KEY = SPARK_SQL_PREFIX + TABLE_CONSTRAINT_PREFIX + "pk"
    +  val TABLE_NUM_FK_CONSTRAINTS = SPARK_SQL_PREFIX + "numFkConstraints"
    +  val TABLE_CONSTRAINT_FOREIGNKEY_PREFIX = SPARK_SQL_PREFIX + TABLE_CONSTRAINT_PREFIX
+ "fk."
    --- End diff --
    
    `SPARK_SQL_PREFIX` is duplicated in `TABLE_CONSTRAINT_PRIMARY_KEY` and `TABLE_CONSTRAINT_FOREIGNKEY_PREFIX`.
    
    E.g., `TABLE_CONSTRAINT_PRIMARY_KEY` is `SPARK_SQL_PREFIX` + `SPARK_SQL_PREFIX` + "constraint.".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message