spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark issue #18849: [SPARK-21617][SQL] Store correct table metadata when alt...
Date Sun, 20 Aug 2017 23:11:28 GMT
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/18849
  
    If `ALTER TABLE` makes the hive compatibility broken, the value of this flag becomes misleading.
Currently, the naming of this flag is pretty general. I expect this flag could be used for
the other places in the future (besides `ALTER TABLE ADD COLUMN`). Introducing a flag is simple
but maintaining the flag needs more works. That is why we do not want to introduce the extra
new flags if they are not required.
    
    If we want to introduce such a flag, we also need to ensure the value is always true.
That means, we need to follow [what we are doing in the CREATE TABLE code path](https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala#L364-L374).
When Hive metastore complained about it, we should also set it to `false`. 
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message