spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From budde <...@git.apache.org>
Subject [GitHub] spark pull request #18029: [SPARK-20168] [DStream] Add changes to use kinesi...
Date Sun, 20 Aug 2017 16:49:15 GMT
Github user budde commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18029#discussion_r134120545
  
    --- Diff: external/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisInputDStreamBuilderSuite.scala
---
    @@ -104,12 +103,61 @@ class KinesisInputDStreamBuilderSuite extends TestSuiteBase with
BeforeAndAfterE
           .build()
         assert(dstream.endpointUrl == customEndpointUrl)
         assert(dstream.regionName == customRegion)
    -    assert(dstream.initialPositionInStream == customInitialPosition)
    +    assert(dstream.initialPosition.initialPositionInStream
    --- End diff --
    
    *nit* Again, I think this could be simplified to:
    
    ```scala
    assert(dstream.initialPosition == customInitialPosition)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message