spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #18849: [SPARK-21617][SQL] Store correct table metadata w...
Date Fri, 18 Aug 2017 07:52:52 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18849#discussion_r133899594
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala
---
    @@ -1175,6 +1205,27 @@ private[spark] class HiveExternalCatalog(conf: SparkConf, hadoopConf:
Configurat
         client.listFunctions(db, pattern)
       }
     
    +  /** Detect whether a table is stored with Hive-compatible metadata. */
    +  private def isHiveCompatible(table: CatalogTable): Boolean = {
    --- End diff --
    
    Why the following logics does not work? Could you share the example we can try?
    ```Scala
          val schemaFromTableProps = getSchemaFromTableProperties(table)
          val partColumnNames = getPartitionColumnsFromTableProperties(table)
          val reorderedSchema = reorderSchema(schema = schemaFromTableProps, partColumnNames)
          val isHiveCompatible  = DataType.equalsIgnoreCaseAndNullability(reorderedSchema,
table.schema)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message