spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request #18972: [SPARK-21720][SQL] Fix 64KB JVM bytecode limit pr...
Date Fri, 18 Aug 2017 04:51:17 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18972#discussion_r133879240
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
    @@ -789,6 +789,36 @@ class CodegenContext {
       }
     
       /**
    +   * Wrap the generated code of expression by a function. ev,isNull and ev.value are
passed
    +   * by global variables
    --- End diff --
    
    Not arbitrary codes all can be wrapped by this. The codes must be only created from a
row object. We should note this in the comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message