spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #18887: [SPARK-20642][core] Store FsHistoryProvider listi...
Date Tue, 15 Aug 2017 22:21:08 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18887#discussion_r133318822
  
    --- Diff: scalastyle-config.xml ---
    @@ -86,7 +86,7 @@ This file is divided into 3 sections:
       </check>
     
       <check level="error" class="org.scalastyle.scalariform.ObjectNamesChecker" enabled="true">
    -    <parameters><parameter name="regex"><![CDATA[[A-Z][A-Za-z]*]]></parameter></parameters>
    +    <parameters><parameter name="regex"><![CDATA[(config|[A-Z][A-Za-z]*)]]></parameter></parameters>
    --- End diff --
    
    That could be done, but I want this to be the "official" pattern going forward, and having
to disable scalastyle every time it's used is kinda ugly and somewhat detracts from the official-ness
of it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message