spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From heary-cao <...@git.apache.org>
Subject [GitHub] spark issue #18914: [MINOR][SQL][TEST]no uncache table in joinsuite test
Date Sun, 13 Aug 2017 12:12:36 GMT
Github user heary-cao commented on the issue:

    https://github.com/apache/spark/pull/18914
  
    @kiszk 
    The original reason of this PR was a simple .
    
      test("broadcasted hash outer join operator selection") {
        spark.sharedState.cacheManager.clearCache()
        sql("CACHE TABLE testData")
        sql("CACHE TABLE testData2")
        Seq(
          ("SELECT * FROM testData LEFT JOIN testData2 ON key = a",
            classOf[BroadcastHashJoinExec]),
          ("SELECT * FROM testData RIGHT JOIN testData2 ON key = a where key = 2",
            classOf[BroadcastHashJoinExec]),
          ("SELECT * FROM testData right join testData2 ON key = a and key = 2",
            classOf[BroadcastHashJoinExec])
        ).foreach(assertJoin)
        sql("UNCACHE TABLE testData")
      }
    the _cache table_ and _uncache table_ do not match.
    Later, we found that replace _uncache table_ with _spark.sharedState.cacheManager.clearCache()_
 
    Finally, it's now modified it.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message