spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ash211 <...@git.apache.org>
Subject [GitHub] spark pull request #18913: [SPARK-21563][CORE] Fix race condition when seria...
Date Fri, 11 Aug 2017 15:55:27 GMT
Github user ash211 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18913#discussion_r132721021
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -1792,6 +1796,9 @@ class SparkContext(config: SparkConf) extends Logging {
     
       /**
        * Adds a JAR dependency for all tasks to be executed on this `SparkContext` in the
future.
    +   *
    +   * If a jar is added during execution, it will not be available until the next TaskSet
starts.
    --- End diff --
    
    This additional sentence is probably overkill, since I'm sure there are many other subtleties
about these methods that aren't spelled out in the Javadoc.
    
    I'm happy to remove and keep these docs simple if that's what a committer would prefer
before merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message